[all-commits] [llvm/llvm-project] 60a378: [C++20] [Modules] Handle modules visible relations...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Tue May 9 03:37:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60a3784b3e1f0e65e2a0e6daf070bbc7cd4bbab5
      https://github.com/llvm/llvm-project/commit/60a3784b3e1f0e65e2a0e6daf070bbc7cd4bbab5
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M clang/lib/Sema/SemaLookup.cpp
    A clang/test/Modules/named-modules-adl-3.cppm
    A clang/test/Modules/pr62589.cppm

  Log Message:
  -----------
  [C++20] [Modules] Handle modules visible relationship properly

Close https://github.com/llvm/llvm-project/issues/62589.

Previously, for global module fragments, we will justify if it is
visible by the visibility of their top level parents. But this is an
overkill, it is problematic if we have a deduction guide in the global
module fragments. See the attached test for example. In this example, we
will mark the global module fragments as visible, but our old strategy
will miss the case surprisingly due to we will only search for the top
level modules.




More information about the All-commits mailing list