[all-commits] [llvm/llvm-project] 91b6d3: [libc] Make the opcode parameter a compile time co...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon May 8 09:16:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91b6d319cb2b6662fcafb542b955e6b377204ee7
      https://github.com/llvm/llvm-project/commit/91b6d319cb2b6662fcafb542b955e6b377204ee7
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M libc/src/__support/OSUtil/gpu/io.cpp
    M libc/src/__support/OSUtil/gpu/quick_exit.cpp
    M libc/src/__support/RPC/rpc.h
    M libc/test/integration/startup/gpu/rpc_test.cpp

  Log Message:
  -----------
  [libc] Make the opcode parameter a compile time constant

Currently the opcode is only valid if it is the same between all of the
ports. This is possible to violate if the opcode is places into a memory
location and then read in a non-uniform manner by the warp / wavefront.
Moving this to a compile time constant makes it impossible to break this
invariant.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D150115




More information about the All-commits mailing list