[all-commits] [llvm/llvm-project] 5b388f: [C++20] [Modules] Don't check input files for C++2...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Fri May 5 20:21:29 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b388f86aa9ce65778677ae56587867d6786355e
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-05-06 (Sat, 06 May 2023)

  Changed paths:
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/cxx20-no-check-input.cppm

  Log Message:
  [C++20] [Modules] Don't check input files for C++20 Modules

Close https://github.com/llvm/llvm-project/issues/62269

Currently, the compiler will emit errors when we compile C++20 modules
if the referenced files changed or got removed. This is because we reuse
the existing logic from Clang implicit modules. It is helpful for clang
implicit modules since it is implicit and we want to be sure things
don't go wrong. But it is not necessary for C++20 modules. The C++20
modules is explicit and it is build systems' responsibility to maintain
the dependencies. So the check in the compiler side may be an overkill.

More information about the All-commits mailing list