[all-commits] [llvm/llvm-project] 7f00ba: Restore mlir-opt `--run-reproducer` option to opt-...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Thu May 4 11:09:48 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f00ba08aade787da6ef891156315698959e7af8
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M mlir/docs/PassManagement.md
    M mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
    M mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
    M mlir/test/Pass/run-reproducer.mlir

  Log Message:
  Restore mlir-opt `--run-reproducer` option to opt-in running a reproducer

When tooling out there produces a reproducer that is archived, the first thing
a user is likely to expect is to process this as they do with any MLIR file.
However https://reviews.llvm.org/D126447 changed the behavior of mlir-opt to
eliminate the `--run-reproducer` option and instead automatically run it when
present in the input file. This creates a discrepancy in how mlir-opt behaves
when fed with an input file, and is surprising for users.
The explicit passing of `--run-reproducer` to express user-intent seems more
in line with what is expected from `mlir-opt`.

Reviewed By: rriddle, jpienaar

Differential Revision: https://reviews.llvm.org/D149820

More information about the All-commits mailing list