[all-commits] [llvm/llvm-project] 053bf8: MS inline asm: remove obsolete code adding AOK_Siz...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu May 4 09:42:38 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 053bf8640aa85911823c2fc98538474c42d33b7a
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M clang/test/CodeGen/mozilla-ms-inline-asm.c
    M clang/test/CodeGen/ms-inline-asm-64.c
    M clang/test/CodeGen/ms-inline-asm.c
    M clang/test/CodeGen/ms-inline-asm.cpp
    M clang/test/CodeGen/ms_this.cpp
    M clang/test/CodeGenCXX/ms-inline-asm-fields.cpp
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

  Log Message:
  MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

The AOK_SizeDirective part from 5b37c181291210bedfbb7a6af5d51229f3652ef0
(2014-08) seems unneeded nowadays (the root cause has likely been fixed
elsewhere). The part abuses that `call dword ptr foo` assembles the same way as `call
foo` in Intel syntax, which is going to be fixed (changed) by D149579.

The generated object files for
CodeGen/ms-inline-asm{,-functions,-variables,-static-variable}.c and
CodeGenCXX/ms-inline-asm-fields.cpp are unchanged
(-mno-incremental-linker-compatible) with just this patch. When D149579 is
subsequently applied, the FIXME part of `kptr` in
CodeGen/ms-inline-asm-functions.c will be fixed.

Differential Revision: https://reviews.llvm.org/D149695

More information about the All-commits mailing list