[all-commits] [llvm/llvm-project] cd05ff: [lldb] Remove distribution_id from ArchSpec

Alex via All-commits all-commits at lists.llvm.org
Wed May 3 10:36:31 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd05ffdbb2c303cbf476a3a48b3f67094d428e37
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M lldb/include/lldb/Host/HostInfoBase.h
    M lldb/include/lldb/Utility/ArchSpec.h
    M lldb/source/Host/linux/HostInfoLinux.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
    M lldb/source/Utility/ArchSpec.cpp

  Log Message:
  [lldb] Remove distribution_id from ArchSpec

The qHostInfo packet in the gdb-remote communication protocol specifies
that distribution_id can be set, so lldb handles that. But we store that
in the ArchSpec representing the "Host" platform (whatever platform the
debug server is running on). This field is otherwise unused in ArchSpec,
so it would be a lot easier if we stored that information at the
gdb-remote communication layer.

Sidenote: The distribution_id field is currently unused but I did not
want to remove it in case some folks found it useful (e.g. in downstream

Differential Revision: https://reviews.llvm.org/D149697

More information about the All-commits mailing list