[all-commits] [llvm/llvm-project] e2f8f7: [libc] Enable the 'stdlib' unit tests to be hermetic

Joseph Huber via All-commits all-commits at lists.llvm.org
Wed May 3 09:38:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e2f8f77e159ba345b5f1dc8531342da7c0d3370e
      https://github.com/llvm/llvm-project/commit/e2f8f77e159ba345b5f1dc8531342da7c0d3370e
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M libc/test/UnitTest/RoundingModeUtils.cpp
    M libc/test/src/CMakeLists.txt
    M libc/test/src/stdlib/CMakeLists.txt

  Log Message:
  -----------
  [libc] Enable the 'stdlib' unit tests to be hermetic

This changes the `stdlib` tests to the new `add_libc_test` framework.
This applies to all but the exit tests.

Depends on D149691

Reviewed By: sivachandra, michaelrj

Differential Revision: https://reviews.llvm.org/D149705


  Commit: c00f8f1314479d6f764f89cfa4efe2f23a640adf
      https://github.com/llvm/llvm-project/commit/c00f8f1314479d6f764f89cfa4efe2f23a640adf
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M libc/test/UnitTest/CMakeLists.txt
    M libc/test/src/fenv/CMakeLists.txt

  Log Message:
  -----------
  [libc] Split out FPExceptMatcher from the FP utils

The FPEceptMatcher.cpp file uses system utilities and includes C++
libraries. This patch pulls it out of the main `FPTestHelpers` target so
we can exclude it from hermetic only tests.

Depends on D149705

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D149745


  Commit: 78d7d62c36f54b4264faec8ce38d11f7dd6abfd6
      https://github.com/llvm/llvm-project/commit/78d7d62c36f54b4264faec8ce38d11f7dd6abfd6
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M libc/test/src/__support/CMakeLists.txt
    M libc/test/src/__support/CPP/CMakeLists.txt
    M libc/test/src/__support/FPUtil/CMakeLists.txt
    M libc/test/src/__support/File/CMakeLists.txt
    M libc/test/src/__support/OSUtil/CMakeLists.txt
    M libc/test/src/__support/OSUtil/linux/x86_64/CMakeLists.txt
    M libc/test/src/__support/char_vector_test.cpp

  Log Message:
  -----------
  [libc] Enable the '__support' unit tests to be hermetic

This patch updates the `__support` unit tests to be built as hermetic
tests. The only tests we needed to disable were because of the use of
`realloc` which is not implemented correctly as it doesn't copy the
memory.

Depends on D149745

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D149750


  Commit: fe710ffe97333d4a9e5af182cc213bbddc45ed66
      https://github.com/llvm/llvm-project/commit/fe710ffe97333d4a9e5af182cc213bbddc45ed66
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M libc/cmake/modules/LLVMLibCTestRules.cmake

  Log Message:
  -----------
  [libc] Don't use '-nolibc' on the GPU build

We previously changed this to use `nolibc` to allow it to link in
compiler builtins for the CPU build. However, these options are unused
on the GPU and create a lot of noise. Furthermore, we want to use
`nogpulib` to prevent the linking in of the vendor libraries.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D149753


Compare: https://github.com/llvm/llvm-project/compare/bc2cf42015a8...fe710ffe9733


More information about the All-commits mailing list