[all-commits] [llvm/llvm-project] 297c10: [NFC][EarlyCSE]Modify test case to ensure branch w...

Mingming Liu via All-commits all-commits at lists.llvm.org
Tue May 2 17:35:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 297c10fd175a2f0ff7cb293fcb2d149b065eaabe
      https://github.com/llvm/llvm-project/commit/297c10fd175a2f0ff7cb293fcb2d149b065eaabe
  Author: Mingming Liu <mingmingl at google.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M llvm/test/Transforms/EarlyCSE/basic.ll

  Log Message:
  -----------
  [NFC][EarlyCSE]Modify test case to ensure branch weights are preserved with cse.

Differential Revision: https://reviews.llvm.org/D149390


  Commit: bb4ba96ed2bd8ca7cc902abb07385a4058fe3ee6
      https://github.com/llvm/llvm-project/commit/bb4ba96ed2bd8ca7cc902abb07385a4058fe3ee6
  Author: Mingming Liu <mingmingl at google.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    A llvm/test/Transforms/EarlyCSE/metadata.ll

  Log Message:
  -----------
  [NFC] Add a test case to make sure EarlyCSE preserves !prof when one
instruction CSE'ed another.

- This should be a part of D148877. Before that patch, !prof is not added to known-id-set [1], and turns out unknown types of metadata are dropped in the implementation [2].
  - This test is mainly added to make sure there won't be regressions for this kind of pattern. The pattern is observed it in application code; looks like the result of indirect call is used as function arguments initially; after the function is inlined load-after-store CSE opportunity is exposed.

  [1] https://github.com/llvm/llvm-project/blob/f478721231bdb71ba8f0f6fb21673b9b7f652add/llvm/lib/Transforms/Utils/Local.cpp#L2727-L2741
  [2] https://github.com/llvm/llvm-project/blob/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9/llvm/lib/Transforms/Utils/Local.cpp#L2639

Differential Revision: https://reviews.llvm.org/D149396


Compare: https://github.com/llvm/llvm-project/compare/fa53ce0faaa0...bb4ba96ed2bd


More information about the All-commits mailing list