[all-commits] [llvm/llvm-project] 3e3c6f: Revert "[Demangle] make llvm::demangle take std::s...

[Nick Desaulniers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e3c6f24ff85ea52ed67d4c26f1d3d0eacd1ad1b
      https://github.com/llvm/llvm-project/commit/3e3c6f24ff85ea52ed67d4c26f1d3d0eacd1ad1b
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M clang/lib/CodeGen/CodeGenAction.cpp
    M lld/COFF/Symbols.cpp
    M lld/ELF/SymbolTable.cpp
    M lld/ELF/Symbols.cpp
    M lld/MachO/Symbols.cpp
    M lld/wasm/Symbols.cpp
    M llvm/docs/ReleaseNotes.rst
    M llvm/include/llvm/Demangle/Demangle.h
    M llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp
    M llvm/lib/Demangle/Demangle.cpp
    M llvm/lib/IR/DiagnosticInfo.cpp
    M llvm/tools/llvm-objdump/ELFDump.cpp
    M llvm/tools/llvm-objdump/XCOFFDump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-readobj/ELFDumper.cpp
    M llvm/tools/llvm-tli-checker/llvm-tli-checker.cpp

  Log Message:
  -----------
  Revert "[Demangle] make llvm::demangle take std::string_view rather than const std::string&"

This reverts commit c117c2c8ba4afd45a006043ec6dd858652b2ffcc.

itaniumDemangle calls std::strlen with the results of
std::string_view::data() which may not be NUL-terminated. This causes
lld/test/wasm/why-extract.s  to fail when "expensive checks" are enabled
via -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON. See D149675 for further
discussion. Back this out until the individual demanglers are converted
to use std::string_view.