[all-commits] [llvm/llvm-project] e15d6b: [lldb][DWARFExpression] Fix DW_OP_div to use signe...

Michael Buch via All-commits all-commits at lists.llvm.org
Tue May 2 04:39:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e15d6b520e1e85d2cdf9ffc66f0c4698390eaa3d
      https://github.com/llvm/llvm-project/commit/e15d6b520e1e85d2cdf9ffc66f0c4698390eaa3d
  Author: LU Hongyi <jwnhy0 at gmail.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    A lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s

  Log Message:
  -----------
  [lldb][DWARFExpression] Fix DW_OP_div to use signed division

This patch resolves an issue where a value
is incorrectly displayed if it is represented
by DW_OP_div.

This issue is caused by lldb evaluating
operands of DW_OP_div as unsigned
and performed unintended unsigned
division.

This issue is resolved by creating two
temporary signed scalar and performing
signed division.

(Addresses GH#61727)

Differential Revision: https://reviews.llvm.org/D147370


  Commit: 52882de0e641487329c9e093a90ea3dad01842c8
      https://github.com/llvm/llvm-project/commit/52882de0e641487329c9e093a90ea3dad01842c8
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M lldb/test/API/lang/cpp/standards/cpp20/Makefile
    M lldb/test/API/lang/cpp/standards/cpp20/TestCPP20Standard.py

  Log Message:
  -----------
  [lldb][test] TestCPP20Standard.py: make it a libc++ test

We just want to test whether the language switch works.
This is easier to control for libc++, since for bots building
the tests against libstdc++ we might not have the necessary
`<compare>` header available currently.


Compare: https://github.com/llvm/llvm-project/compare/2cdb6b84c157...52882de0e641


More information about the All-commits mailing list