[all-commits] [llvm/llvm-project] 467627: [LLD][COFF] Print object file name for unsupported...

alvinhochun via All-commits all-commits at lists.llvm.org
Mon May 1 21:13:41 PDT 2023

  Branch: refs/heads/release/16.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 4676274c9eb222c745c7402d83872b4a28d66f41
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-01 (Mon, 01 May 2023)

  Changed paths:
    M lld/COFF/Driver.cpp
    A lld/test/COFF/directives-unsupported.s

  Log Message:
  [LLD][COFF] Print object file name for unsupported directives

This is a small QoL improvement suggested by FrancescElies in

Differential Revision: https://reviews.llvm.org/D149022

(cherry picked from commit 9b15e9840f5073aa38939fbef1cb0c64dcc5f02f)

  Commit: 7a26555f8d48ae47cd7f6642263cbaffa08bf4d0
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-01 (Mon, 01 May 2023)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/COFF/Options.td
    A lld/test/COFF/inferasanlibs-drectve.s
    A lld/test/COFF/inferasanlibs.test

  Log Message:
  [LLD][COFF] Add /inferasanlibs to lld-link as ignored flag

MSVC link.exe added this flag and MS STL started using this flag in
.drectve [1] when compiling with Clang with asan enabled, as reported
on https://github.com/llvm/llvm-project/issues/56300. This causes issues
with lld-link because it rejects any unknown flags in .drective sections.

As dc07867dc9991c982bd3441da19d6fcc16ea54d6 noted that, when using Clang
as the driver it explicitly passes the proper asan libraries. Therefore
it should be acceptable to ignore this flag in lld-link to at least
unbreak building with clang-cl and linking with lld-link.

[1]: https://github.com/microsoft/STL/blob/faaf094ee16bcbfb2c8d612fdb9334bcdef2fd0a/stl/inc/__msvc_sanitizer_annotate_container.hpp#L35

Differential Revision: https://reviews.llvm.org/D149023

(cherry picked from commit 8fa0cfeb61a12ad5ca7830a8228155de32aa7ab2)

Compare: https://github.com/llvm/llvm-project/compare/e86119670799...7a26555f8d48

More information about the All-commits mailing list