[all-commits] [llvm/llvm-project] 91528d: [libc] Fix printing on the GPU when given a `cpp::...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Apr 28 19:32:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91528d20584066e393a926a3430e9380f394dabc
      https://github.com/llvm/llvm-project/commit/91528d20584066e393a926a3430e9380f394dabc
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M libc/src/__support/OSUtil/gpu/io.cpp
    M libc/utils/gpu/loader/Server.h

  Log Message:
  -----------
  [libc] Fix printing on the GPU when given a `cpp::string_ref`

The implementation of the test printing currently expects a null
terminated C-string. However, the `write_to_stderr` interface uses a
string view, which doesn't need to be null terminated. This patch
changes the printing interface to directly use `fwrite` instead rather
than relying on a null terminator.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D149493




More information about the All-commits mailing list