[all-commits] [llvm/llvm-project] ade3c6: Host: generalise `GetXcodeSDKPath`

Saleem Abdulrasool via All-commits all-commits at lists.llvm.org
Fri Apr 28 09:31:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9
      https://github.com/llvm/llvm-project/commit/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M lldb/include/lldb/Host/HostInfoBase.h
    M lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
    M lldb/source/Core/Module.cpp
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
    M lldb/unittests/Host/HostInfoTest.cpp

  Log Message:
  -----------
  Host: generalise `GetXcodeSDKPath`

This generalises the GetXcodeSDKPath hook to a GetSDKRoot path which
will be re-used for the Windows support to compute a language specific
SDK path on the platform. Because there may be other options that we
wish to use to compute the SDK path, sink the XcodeSDK parameter into
a structure which can pass a disaggregated set of options. Furthermore,
optionalise the parameter as Xcode is not available for all platforms.

Differential Revision: https://reviews.llvm.org/D149397
Reviewed By: JDevlieghere




More information about the All-commits mailing list