[all-commits] [llvm/llvm-project] 9c1e4e: [NFC]Fix 2 logic dead code

XinWang10 via All-commits all-commits at lists.llvm.org
Fri Apr 28 00:03:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c1e4ee6902a8a827dcc9132c3f742a28238dd20
      https://github.com/llvm/llvm-project/commit/9c1e4ee6902a8a827dcc9132c3f742a28238dd20
  Author: Wang, Xin10 <xin10.wang at intel.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M llvm/lib/CodeGen/CodeGenPrepare.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

  Log Message:
  -----------
  [NFC]Fix 2 logic dead code

First, in CodeGenPrepare.cpp, line 6891, the VectorCond will always be false
because if not function will return at 6888.
Second, in SelectionDAGBuilder.cpp, line 5443, getSExtValue() will return
value as int type, but now we use unsigned Val to maintain it, which make the
if condition at 5452 meaningless.

Reviewed By: skan

Differential Revision: https://reviews.llvm.org/D149033




More information about the All-commits mailing list