[all-commits] [llvm/llvm-project] 1ec4e1: [libcxx] [test] Print the failing commands in Conf...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ec4e139efb474d98b38c4f6c5f0ee3750b21c69
      https://github.com/llvm/llvm-project/commit/1ec4e139efb474d98b38c4f6c5f0ee3750b21c69
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M libcxx/utils/libcxx/test/dsl.py

  Log Message:
  -----------
  [libcxx] [test] Print the failing commands in Configuration{Compilation,Runtime}Error

This allows for easier debugging of the test environment when something
fails.

Differential Revision: https://reviews.llvm.org/D145807


  Commit: eb5f9a5a521ba1786a2648b2d9b36b506ebd26e4
      https://github.com/llvm/llvm-project/commit/eb5f9a5a521ba1786a2648b2d9b36b506ebd26e4
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M libcxx/utils/ssh.py

  Log Message:
  -----------
  [libcxx] [test] Unbreak passing multiple env variables in ssh.py

No test actually does this, but this makes the option behave like
the corresponding one in run.py.

This was broken by commit b8b23aa80eefe84187d6ba364d06496c90c53bdb
(https://reviews.llvm.org/D99242) which introduced quoting; instead
of quoting the whole space separated list, quote each individual
argument.

Differential Revision: https://reviews.llvm.org/D149319


  Commit: ba3bddb6f4736b99437c069d61f4e558c6198e5a
      https://github.com/llvm/llvm-project/commit/ba3bddb6f4736b99437c069d61f4e558c6198e5a
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M libcxx/test/configs/llvm-libc++-mingw.cfg.in
    M libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
    M libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
    M libcxx/utils/run.py
    M libcxx/utils/ssh.py
    M libcxxabi/test/configs/llvm-libc++abi-mingw.cfg.in
    M libcxxabi/test/configs/llvm-libc++abi-shared-clangcl.cfg.in
    M libcxxabi/test/configs/llvm-libc++abi-static-clangcl.cfg.in
    M libunwind/test/configs/llvm-libunwind-mingw.cfg.in

  Log Message:
  -----------
  [libcxx] [test] Prepend to PATH instead of overriding it

On Windows, the PATH env variable is used for locating dynamically
linked librarys, akin to LD_LIBRARY_PATH on Linux.

The tests that run with a dynamically linked libc++ used "--env
PATH=%{lib}" in the test config. This had the unfortunate side effect
of making other tools from PATH unavailable during the runtime of the
tests; in particular, it caused the "executor-has-no-bash" flag to be
set for all those Windows test configs (with the clang-cl static config
being the only one lacking it).

Thus, this increases the number of tests actually included in the
clang-cl dll and all mingw test configs by 9 tests.

The clang-cl static test configuration has been executing those tests
since the "--env PATH=%{lib}" was removed from that test config in
e78223e79efc886ef6f0ea5413deab3737d6d63b. (For mingw we haven't had a
need to split the test config between shared and static, which means
that the mingw static test config previously ran with --env PATH
needlessly.)

This increases the test coverage for patches like D146398 which
can't be executed in the executor-has-no-bash configs.

Change the default value of the arg.env to an empty array; when we do
pass values to the option, they get passed as an array of strings,
so make sure the variable behaves consistently when no arguments
have been passed.

Differential Revision: https://reviews.llvm.org/D148324


Compare: https://github.com/llvm/llvm-project/compare/4249d609ac9f...ba3bddb6f473