[all-commits] [llvm/llvm-project] 61be93: [MLIR][Linalg] Change destination logic in `bubble...

lorenzo chelini via All-commits all-commits at lists.llvm.org
Thu Apr 27 01:10:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61be9358963806f6dfd118cd7602a67e8ec01c82
      https://github.com/llvm/llvm-project/commit/61be9358963806f6dfd118cd7602a67e8ec01c82
  Author: Lorenzo Chelini <l.chelini at icloud.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
    M mlir/test/Dialect/Linalg/data-layout-propagation.mlir

  Log Message:
  -----------
  [MLIR][Linalg] Change destination logic in `bubbleUpPackOpThroughGenericOp`.

In `bubbleUpPackOpThroughGenericOp`, we replaced the init operands with
a new `tensor.empty` if the operation was a pure element-wise op. This
behaviour is not wrong but not ideal because we "break" the original
use-def-chain of the output operand by materializing a new
`tensor.empty`. We should use `tensor.empty` as a destination *only* if the
initial init operand was already a `tensor.empty`, as we do in
`PushDownUnpack`.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D149250




More information about the All-commits mailing list