[all-commits] [llvm/llvm-project] 71f862: [flang] Account for .exe suffix in test/Driver/omp...

Markus Mützel via All-commits all-commits at lists.llvm.org
Tue Apr 25 10:17:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 71f862b7bb2c2413d9e47d281ed6f901f8bcd6e3
      https://github.com/llvm/llvm-project/commit/71f862b7bb2c2413d9e47d281ed6f901f8bcd6e3
  Author: Slava Zakharin <szakharin at nvidia.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M flang/test/Driver/omp-driver-offload.f90

  Log Message:
  -----------
  [flang] Account for .exe suffix in test/Driver/omp-driver-offload.f90.

I believe this test started failing pre-commit testing after D148038.
For example:
https://buildkite.com/llvm-project/premerge-checks/builds/148654#0187b72b-7360-4c52-be94-93eefcb269f4
https://buildkite.com/llvm-project/premerge-checks/builds/148642#0187b691-15a7-44c4-ae23-c7e97ec67755

On Windows the .exe suffix is used for clang-offload-packager tool:
"c:\\program files\\llvm\\bin\\clang-offload-packager.exe" ...

At the same time, I believe I have seen this test sporadically fail before,
meaning that the .exe suffix is not added consistently. I am not sure
why this might be happening. I decided just to allow the suffix.


  Commit: 329964769972ef3c8a68f2dfea30e66beb4ae3e2
      https://github.com/llvm/llvm-project/commit/329964769972ef3c8a68f2dfea30e66beb4ae3e2
  Author: Markus Mützel <markus.muetzel at gmx.de>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M flang/runtime/time-intrinsic.cpp

  Log Message:
  -----------
  [flang] Avoid dependency of runtime library on pthread for MinGW

When building the Fortran runtime on MinGW, `clock_gettime` is currently used. That function is provided by the `pthread` library on that platform. That means that all programs that link `libFortranRuntime` also require to be linked with `pthread` on that platform.

There is already a code path (for MSVC) that doesn't use `clock_gettime` in the implementation of the Fortran library.
Use the same code path also on MinGW by undefining `CLOCKID`.

Reviewed By: vzakhari

Differential Revision: https://reviews.llvm.org/D149051


Compare: https://github.com/llvm/llvm-project/compare/6600ea1d1c7a...329964769972


More information about the All-commits mailing list