[all-commits] [llvm/llvm-project] 65eedc: [mlir] detensorize: don't accidentally convert fun...

ftynse via All-commits all-commits at lists.llvm.org
Mon Apr 24 20:34:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 65eedcebdc03052959508911417bac548009652a
      https://github.com/llvm/llvm-project/commit/65eedcebdc03052959508911417bac548009652a
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Detensorize.cpp
    A mlir/test/Dialect/Linalg/detensorize_entry_block.mlir
    M mlir/test/Dialect/Linalg/detensorize_while_pure_cf.mlir

  Log Message:
  -----------
  [mlir] detensorize: don't accidentally convert function entry blocks

In the Linalg detensorize pass, dialect conversion could accidentally
trigger signature conversion of the function entry block after inlining
the body of a Linalg generic into it. Such a conversion is not desirable
because it would break the internal validity of the function op, that is
futhermore not supposed to be detensorized at the boundary. Mitigate
this by creating a dummy (empty) entry block so Linalg operations are
never inlined into it and the conversion is never triggered.

Closes #62249.

Reviewed By: silvas

Differential Revision: https://reviews.llvm.org/D148983




More information about the All-commits mailing list