[all-commits] [llvm/llvm-project] 7ead39: [llvm-exegesis] Fix ifdefs in X86/Target.cpp

Pavel Kosov via All-commits all-commits at lists.llvm.org
Mon Apr 24 12:33:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ead39aca61eb9df92d8920c771912c0bad3e469
      https://github.com/llvm/llvm-project/commit/7ead39aca61eb9df92d8920c771912c0bad3e469
  Author: Pavel Kosov <kpdev42 at gmail.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/X86/latency/dummy-counters.test
    M llvm/tools/llvm-exegesis/lib/X86/Target.cpp

  Log Message:
  -----------
  [llvm-exegesis] Fix ifdefs in X86/Target.cpp

As discussed in https://reviews.llvm.org/D96498, the correct macro
to check together with _MSC_VER is _M_X64. Testing for _MSC_VER with
__x86_64__ made tests fail on Windows in https://reviews.llvm.org/D146301.

Additionally, this commit replaces a few calls to llvm_unreachable() with
report_fatal_error() because it is actually reached even on Linux/i686,
causing obscure segfaults when expanded to __builtin_unreachable().

~~

Huawei RRI, OS Lab

Reviewed By: courbet

Differential Revision: https://reviews.llvm.org/D147926




More information about the All-commits mailing list