[all-commits] [llvm/llvm-project] 271a73: [dataflow] HTMLLogger: fix off-by-one in the BB li...

[Sam McCall via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 271a73dae32f5eac2011a2f85351975484496262
      https://github.com/llvm/llvm-project/commit/271a73dae32f5eac2011a2f85351975484496262
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/HTMLLogger.html

  Log Message:
  -----------
  [dataflow] HTMLLogger: fix off-by-one in the BB listing

The indexes of analysis state within a BB element is a bit odd:
  BB.0 is the initial state
  BB.1 is the state after the first element
etc

This means we have N+1 states and we need N+1 elements in the BB list.
We add a dummy element at the beginning rather than the end, because we want
selecting a CFG element to show the state *afterwards*.
For example, if we click on an expr, we want to be able to see its value model!

Differential Revision: https://reviews.llvm.org/D148951