[all-commits] [llvm/llvm-project] 1d5fa4: [symbolizer] Change error message if module not fo...

[Serge Pavlov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d5fa4f88f636f99f55933c919789662518cb951
      https://github.com/llvm/llvm-project/commit/1d5fa4f88f636f99f55933c919789662518cb951
  Author: Serge Pavlov <sepavloff at gmail.com>
  Date:   2023-04-23 (Sun, 23 Apr 2023)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cpp
    M llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
    M llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
    M llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
    M llvm/test/DebugInfo/Symbolize/ELF/symtab-file2.yaml
    M llvm/test/DebugInfo/symbolize-missing-file.test
    M llvm/test/tools/llvm-symbolizer/debuginfod-missing-build-id.test
    M llvm/test/tools/llvm-symbolizer/output-style-inlined.test
    M llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
    M llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

  Log Message:
  -----------
  [symbolizer] Change error message if module not found (recommit)

This is a recommit of 75f1f158812d, reverted in 7a443b1c493d, because
it caused compilation error in
compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cpp.
The error was fixed by Kasimir Georgiev in de4c038c7ba2, but this
commit was reverted in de088dd3a0aa, because the initial commit was
reverted.

This commit reverts both the reverting commits, 7a443b1c493d and
de088dd3a0aa.

Original commit message is below.

If llvm-symbolize did not find module, the error looked like:

    LLVMSymbolizer: error reading file: No such file or directory

This message does not follow common practice: LLVMSymbolizer is not an
utility name. Also the message did not not contain the name of missed file.

With this change the error message looks differently:

    llvm-symbolizer: error: 'abc': No such file or directory

This format is closer to messages produced by other utilities and allow
proper coloring.

Differential Revision: https://reviews.llvm.org/D148032