[all-commits] [llvm/llvm-project] ebee5e: [Object] Always initialized StartOfFile in Archive...

jacekcw via All-commits all-commits at lists.llvm.org
Fri Apr 21 17:04:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ebee5e0473df7685086eb2f4ffb07e1bf965b3bd
      https://github.com/llvm/llvm-project/commit/ebee5e0473df7685086eb2f4ffb07e1bf965b3bd
  Author: Jacek Caban <jacek at codeweavers.com>
  Date:   2023-04-22 (Sat, 22 Apr 2023)

  Changed paths:
    M llvm/lib/Object/Archive.cpp

  Log Message:
  -----------
  [Object] Always initialized StartOfFile in Archive::Child::Child constructor.

Fixes uninitialized memory access revealed by https://reviews.llvm.org/D146534.

In empty archives, we use Child(nullptr,nullptr,nullptr) in Archive constructor in setFirstRegular. This copies unitialized StartOfFile to FirstRegularStartOfFile, which child_begin may use later.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D148955




More information about the All-commits mailing list