[all-commits] [llvm/llvm-project] 3a30cf: [Demangle] replace std::string_view::substr which ...

[Nick Desaulniers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a30cf212d12cc5013ec67e54530b69ee2cfc7c9
      https://github.com/llvm/llvm-project/commit/3a30cf212d12cc5013ec67e54530b69ee2cfc7c9
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M llvm/include/llvm/Demangle/ItaniumDemangle.h

  Log Message:
  -----------
  [Demangle] replace std::string_view::substr which may throw

llvm/Demangle copies the implementation from libcxxabi/src/demangle/.
libcxxabi/ cannot use potentially-throwing std::string_view::substr, so
change llvm/Demangle to avoid these function calls.

I ran into linkage failures stemming from the usage of
std::string_view::substr. substr does a bounds check and may throw.

Fixes: f198e0b594aa ("[StringView] remove dropFront")

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D148959