[all-commits] [llvm/llvm-project] 6b80f0: [clang][deps] NFC: Refactor and comment ModuleDeps...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Apr 21 10:56:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b80f00bac6a4832af4f8ebde96564690a35f7e1
      https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
    M clang/tools/clang-scan-deps/ClangScanDeps.cpp

  Log Message:
  -----------
  [clang][deps] NFC: Refactor and comment ModuleDeps sorting

I once again stumbled across `IndexedModuleID` and was confused by the mutable `InputIndex` field.

This patch adds comments around that piece of code and unifies/simplifies related functions.

Reviewed By: Bigcheese

Differential Revision: https://reviews.llvm.org/D145197




More information about the All-commits mailing list