[all-commits] [llvm/llvm-project] 737820: Make diagnostics API safer to use

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 737820e6d6e2df50f2ddf522a0db9ffb794ff749
      https://github.com/llvm/llvm-project/commit/737820e6d6e2df50f2ddf522a0db9ffb794ff749
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M lldb/include/lldb/Expression/DiagnosticManager.h
    M lldb/unittests/Expression/DiagnosticManagerTest.cpp

  Log Message:
  -----------
  Make diagnostics API safer to use

I received a crash report in DiagnosticManager that was caused by a
nullptr diagnostic having been added. The API allows passing in a null
unique_ptr, but all the methods are written assuming that all pointers
a dereferencable. This patch makes it impossible to add a null
diagnostic.

rdar://107633615

Differential Revision: https://reviews.llvm.org/D148823