[all-commits] [llvm/llvm-project] 5ea158: Revert "Reland [Modules] Remove unnecessary check ...

Ilya Biryukov via All-commits all-commits at lists.llvm.org
Fri Apr 21 05:08:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ea158077ec9ca50857ede5cbb0b27c61663fd55
      https://github.com/llvm/llvm-project/commit/5ea158077ec9ca50857ede5cbb0b27c61663fd55
  Author: Ilya Biryukov <ibiryukov at google.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/test/Modules/pr61065.cppm

  Log Message:
  -----------
  Revert "Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

This reverts commit 67b298f6d82e0b4bb648ac0dabe895e816a77ef1.

We got linker errors with undefined symbols during a compiler release
and tracked it down to this change. I am in the process of understanding
what is happening and getting a reproducer.

Sorry for reverting this again.

I will reopen #61065 until we fix this.




More information about the All-commits mailing list