[all-commits] [llvm/llvm-project] 6bad76: [Demangle] fix windows tests

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Thu Apr 20 16:41:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6bad76c7ae93a94fbac39db08fee23ce46d97fdb
      https://github.com/llvm/llvm-project/commit/6bad76c7ae93a94fbac39db08fee23ce46d97fdb
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M llvm/lib/Demangle/MicrosoftDemangle.cpp

  Log Message:
  -----------
  [Demangle] fix windows tests

My reland of https://reviews.llvm.org/D148546 has caused a few windows
demangler tests to fail when run with -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON
on windows.

I have a sneaking suspicion that MSVC's
std::string_view::iterator::operator* may be missing a nullptr check.

Link: https://lab.llvm.org/buildbot/#/builders/42/builds/9723/steps/7/logs/stdio

Reviewed By: ayzhao

Differential Revision: https://reviews.llvm.org/D148852




More information about the All-commits mailing list