[all-commits] [llvm/llvm-project] e0d884: [mlir][irdl] Add IRDL registration

Fehr Mathieu via All-commits all-commits at lists.llvm.org
Thu Apr 20 07:36:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0d884de360b5c3fe79c6a53f8f88b57f0e42275
      https://github.com/llvm/llvm-project/commit/e0d884de360b5c3fe79c6a53f8f88b57f0e42275
  Author: Mathieu Fehr <mathieu.fehr at gmail.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    A mlir/include/mlir/Dialect/IRDL/IRDLLoading.h
    M mlir/include/mlir/IR/OpDefinition.h
    M mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
    M mlir/lib/Dialect/IRDL/CMakeLists.txt
    A mlir/lib/Dialect/IRDL/IRDLLoading.cpp
    M mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
    A mlir/test/Dialect/IRDL/test-cmath.mlir
    A mlir/test/Dialect/IRDL/testd.mlir

  Log Message:
  -----------
  [mlir][irdl] Add IRDL registration

This patch add support for loading IRDL dialects at runtime
with `mlir-opt`.

Given the following `dialect.irdl` file:
```mlir
module {
  irdl.dialect @cmath {
    irdl.type @complex {
      %0 = irdl.is f32
      %1 = irdl.is f64
      %2 = irdl.any_of(%0, %1)
      irdl.parameters(%2)
    }

    irdl.operation @norm {
      %0 = irdl.any
      %1 = irdl.parametric @complex<%0>
      irdl.operands(%1)
      irdl.results(%0)
    }
}
```

the IRDL file can be loaded with the `mlir-opt --irdl-file=dialect.irdl`
command, and the following file can then be parsed:

```mlir
func.func @conorm(%p: !cmath.complex<f32>, %q: !cmath.complex<f32>) -> f32 {
  %norm_p = "cmath.norm"(%p) : (!cmath.complex<f32>) -> f32
  %norm_q = "cmath.norm"(%q) : (!cmath.complex<f32>) -> f32
  %pq = arith.mulf %norm_p, %norm_q : f32
  return %pq : f32
}
```

To minimize the size of this patch, the operation, attribute, and type verifier are all always returning `success()`.

Depends on D144692

Reviewed By: rriddle, Mogball, mehdi_amini

Differential Revision: https://reviews.llvm.org/D144693




More information about the All-commits mailing list