[all-commits] [llvm/llvm-project] dd0b7a: [libc++] Adjust D_LIBCPP_ENABLE_ASSERTIONS defines...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Apr 20 04:49:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd0b7a59eb48335a7d5bb953c9a2aa9380291171
      https://github.com/llvm/llvm-project/commit/dd0b7a59eb48335a7d5bb953c9a2aa9380291171
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M libcxx/test/libcxx/utilities/assert.exception_guard.no_exceptions.pass.cpp
    M libcxx/test/libcxx/utilities/exception_guard.no_exceptions.pass.cpp

  Log Message:
  -----------
  [libc++] Adjust D_LIBCPP_ENABLE_ASSERTIONS defines in exception_guard tests

For the assert.FOO.pass.cpp test, we should be passing _LIBCPP_ENABLE_ASSERTIONS=1
for consistency, even though -D_LIBCPP_ENABLE_ASSERTIONS is equivalent.

For the other test, we shouldn't be forcing assertions to be enabled,
since we already have a CI job that enables assertions by default and
will do the right thing.

Differential Revision: https://reviews.llvm.org/D148736




More information about the All-commits mailing list