[all-commits] [llvm/llvm-project] 3125af: [compiler-rt] [test] [profile] Avoid issues with a...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3125af2b6b8a5a502d8cef480a874474b55efef1
      https://github.com/llvm/llvm-project/commit/3125af2b6b8a5a502d8cef480a874474b55efef1
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M compiler-rt/test/profile/instrprof-basic.c
    M compiler-rt/test/profile/instrprof-tmpdir.c

  Log Message:
  -----------
  [compiler-rt] [test] [profile] Avoid issues with an implicit .exe suffix

Mingw toolchains implicitly add an .exe suffix if the output linked
file doesn't have a suffix. In many cases the extra suffix doesn't
cause any issues, but in some tests, this discrepancy between expected
output file name and actual output file does affect the tests.

In one test, a rm command fails to remove the executable since it
doesn't have the expected name. By failing to remove the executable, the
later llvm-profdata command tries to read the executable as if it was
a profile data file.

In another test, when the Python executor executes commands, it can
resolve executable names without the extra .exe suffix for absolute
paths (when most binaries are executed as e.g. "%t/foo"), but it fails
to resolve the executables for relative paths such as "./foo". Making
the paths absolute by using %t here shouldn't affect what the test tries
to validate.

Differential Revision: https://reviews.llvm.org/D148169