[all-commits] [llvm/llvm-project] 692518: [libcxxabi] Omit dllimport in public headers in Mi...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 692518d04b2d170b1ae10c50843e7c497c4a9922
      https://github.com/llvm/llvm-project/commit/692518d04b2d170b1ae10c50843e7c497c4a9922
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M libcxxabi/include/__cxxabi_config.h

  Log Message:
  -----------
  [libcxxabi] Omit dllimport in public headers in MinGW mode

This matches the corresponding change to libcxx headers in
dfa88927ae1411ccc3b248b7e624f2acf623d947.

This avoids needing to define _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
when building libcxxabi tests, for two reasons:
- It defaults to normal linkage (as opposed to dllimport), fixing
  linking of a static library version of libcxx/libcxxabi
- It avoids issues with using dllimport declarations on symbols when
  including cxxabi implementations into the testcase itself

Differential Revision: https://reviews.llvm.org/D148441


  Commit: f3ee6695e0f6232fee96e2e6ccd96e85ed682998
      https://github.com/llvm/llvm-project/commit/f3ee6695e0f6232fee96e2e6ccd96e85ed682998
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp

  Log Message:
  -----------
  [libcxxabi] [test] Avoid mingw warnings about missing a return statement

With current versions of mingw-w64 headers, code following
assert(false) isn't considered unreachable - thus add a dummy
"return nullptr;", to avoid warnings (treated as errors) for a
missing return statement.

The root cause does get fixed further upstream in mingw-w64 in
https://github.com/mingw-w64/mingw-w64/commit/1690994f515910a31b9fb7c7bd3a52d4ba987abe
though.

Differential Revision: https://reviews.llvm.org/D147860


  Commit: 637d572f7b5029504661860d20ab309427eb6090
      https://github.com/llvm/llvm-project/commit/637d572f7b5029504661860d20ab309427eb6090
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M libcxxabi/test/configs/llvm-libc++abi-mingw.cfg.in

  Log Message:
  -----------
  [libcxxabi] [test] Fix the mingw test config

Don't link libc++abi separately in addition to the main -lc++; in
mingw build configs, libc++abi is always bundled into libc++
(via LIBCXX_ENABLE_STATIC_ABI_LIBRARY).

In the case of a shared linked libc++, linking a separate static
libc++abi leads to linker errors.

Differential Revision: https://reviews.llvm.org/D147638


Compare: https://github.com/llvm/llvm-project/compare/045eec61f36b...637d572f7b50