[all-commits] [llvm/llvm-project] c184dc: [mlir][openacc] Add separate acc data operations f...

Razvan Lupusoru via All-commits all-commits at lists.llvm.org
Tue Apr 18 15:37:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c184dcb458909d0d90bed6835761836a0de309a0
      https://github.com/llvm/llvm-project/commit/c184dcb458909d0d90bed6835761836a0de309a0
  Author: Razvan Lupusoru <razvan.lupusoru at gmail.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M flang/lib/Lower/OpenACC.cpp
    M mlir/include/mlir/Dialect/OpenACC/CMakeLists.txt
    M mlir/include/mlir/Dialect/OpenACC/OpenACC.h
    A mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td
    M mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
    A mlir/include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td
    A mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
    M mlir/lib/Dialect/OpenACC/CMakeLists.txt
    M mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
    M mlir/test/Dialect/OpenACC/ops.mlir

  Log Message:
  -----------
  [mlir][openacc] Add separate acc data operations for OpenACC data clauses

As outlined in [1], data clauses are now implemented as separate operations
from the constructs that they belong to. Some of the highlighted benefits:
- Correctly represent dataflow of data operations
- Easier to track debugging information
- Friendlier to add attributes and to optimize operations

For now, all of the other operand lists are being kept until all references
to them in LLVM can be removed (such as those in flang lowering)

[1] https://discourse.llvm.org/t/rfc-openacc-dialect-data-operation-improvements/69825

Reviewed By: clementval, vzakhari

Differential Revision: https://reviews.llvm.org/D148389




More information about the All-commits mailing list