[all-commits] [llvm/llvm-project] 83ae2d: [AMDGPU] Refactor PromoteAlloca implementation

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Tue Apr 18 05:24:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 83ae2d3618c1f959031e78573691f1ea86b7c809
      https://github.com/llvm/llvm-project/commit/83ae2d3618c1f959031e78573691f1ea86b7c809
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp

  Log Message:
  -----------
  [AMDGPU] Refactor PromoteAlloca implementation

We're getting a lot of mileage out of PromoteAlloca, and the pass had grown somewhat organically over the year.
This patch attempts to clean up the implementation and restructure it. For instance,
the exact same code path is now used for both promote alloca to LDS and
promote alloca to vector - just with different parameters.
This removes some redundancy here and there.
I also reordered functions in a way that hopefully makes more sense (e.g. all of the pass API is in the same place)

No functionality change is intended in the patch, but some checks were movved around so I'm not using the NFC tag.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D148526




More information about the All-commits mailing list