[all-commits] [llvm/llvm-project] 2ccbd1: [Assignment Tracking][SelectionDAG] Fix dbg.declar...

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ccbd19473a1e35b88dc4e6c9f0d0b0e5801804d
      https://github.com/llvm/llvm-project/commit/2ccbd19473a1e35b88dc4e6c9f0d0b0e5801804d
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
    M llvm/test/DebugInfo/assignment-tracking/X86/single-memory-location.ll

  Log Message:
  -----------
  [Assignment Tracking][SelectionDAG] Fix dbg.declare location nullptr deref

Debug intrinsics sometimes end up with empty metadata location operands. The
debug intrinsic interfaces return nullptr when retrieving location operand in
this case.

When assignment tracking is not enabled a dbg.declare with a nullptr location
operand is skipped. Do the same when assignment tracking is enabled (a nullptr
address component of a dbg.assign is already handled correctly.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D148203


  Commit: 1950cb4b6839c5befae4945760c484adcbba956d
      https://github.com/llvm/llvm-project/commit/1950cb4b6839c5befae4945760c484adcbba956d
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M llvm/lib/IR/DebugInfo.cpp
    A llvm/test/DebugInfo/Generic/assignment-tracking/declare-to-assign/nullptr-declare.ll

  Log Message:
  -----------
  [Assignment Tracking] Skip empty-metadata dbg.declares in AssignmentTrackingPass

Debug intrinsics sometimes end up with empty metadata location operands. The
debug intrinsic interfaces return nullptr when retrieving location operand in
this case.

Skip empty-metadata dbg.declares to avoid dereferencing the nullptr. This
doesn't affect the final debug info in any way.

Reviewed By: jryans

Differential Revision: https://reviews.llvm.org/D148204


Compare: https://github.com/llvm/llvm-project/compare/912fedfbe5b9...1950cb4b6839