[all-commits] [llvm/llvm-project] 8bddb1: [lldb] Change parameter type of StructuredData::Pa...

Alex via All-commits all-commits at lists.llvm.org
Mon Apr 17 17:25:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8bddb13c2470b95651955c61913627b31e9c99d6
      https://github.com/llvm/llvm-project/commit/8bddb13c2470b95651955c61913627b31e9c99d6
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M lldb/include/lldb/Utility/StructuredData.h
    M lldb/source/API/SBDebugger.cpp
    M lldb/source/API/SBStructuredData.cpp
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Utility/StructuredData.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
    M lldb/unittests/tools/lldb-server/tests/MessageObjects.cpp

  Log Message:
  -----------
  [lldb] Change parameter type of StructuredData::ParseJSON

Instead of taking a `const std::string &` we can take an
`llvm::StringRef`. The motivation for this change is that many of the
callers of `ParseJSON` end up creating a temporary `std::string` from an existing
`StringRef` or `const char *` in order to satisfy the API. There's no
reason we need to do this.

Differential Revision: https://reviews.llvm.org/D148579




More information about the All-commits mailing list