[all-commits] [llvm/llvm-project] 43ac26: [lldb] Lock accesses to PathMappingLists's internals

Alex via All-commits all-commits at lists.llvm.org
Mon Apr 17 14:53:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43ac269bdd00d709005f8f3550db6b657b2bf940
      https://github.com/llvm/llvm-project/commit/43ac269bdd00d709005f8f3550db6b657b2bf940
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M lldb/include/lldb/Target/PathMappingList.h
    M lldb/source/Target/PathMappingList.cpp

  Log Message:
  -----------
  [lldb] Lock accesses to PathMappingLists's internals

This class is not safe in multithreaded code. It's possible for one
thread to modify a PathMappingList's `m_pair` vector while another
thread is iterating over it, effectively invalidating the iterator and
potentially leading to crashes or other difficult-to-diagnose bugs.

rdar://107695786

Differential Revision: https://reviews.llvm.org/D148380




More information about the All-commits mailing list