[all-commits] [llvm/llvm-project] f099f2: [clangd] Use all inputs to SystemIncludeExtractor ...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f099f2fefbab0592c828573d816b46a475076f49
      https://github.com/llvm/llvm-project/commit/f099f2fefbab0592c828573d816b46a475076f49
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M clang-tools-extra/clangd/SystemIncludeExtractor.cpp
    M clang-tools-extra/clangd/test/system-include-extractor.test

  Log Message:
  -----------
  [clangd] Use all inputs to SystemIncludeExtractor in cache key

Instead of passing in a tooling::CompileCommand into system include
extraction, pass a limited set, whose elements are used as keys.

Also fix the issue around accepting `-isysroot=/foo` which isn't a valid
argument (or the directory should be `=/foo` not `/foo`).

Fixes https://github.com/clangd/clangd/issues/1404
Fixes https://github.com/clangd/clangd/issues/1403

This should also unblock https://reviews.llvm.org/D138546

Differential Revision: https://reviews.llvm.org/D146941