[all-commits] [llvm/llvm-project] 73b6b3: [Pipelines] Add LoopSink and DivRemPairs to LTO po...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Apr 17 04:07:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 73b6b323c501870814cdc6b3cee4a66feb6171ef
      https://github.com/llvm/llvm-project/commit/73b6b323c501870814cdc6b3cee4a66feb6171ef
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M llvm/lib/Passes/PassBuilderPipelines.cpp
    M llvm/test/Other/new-pm-lto-defaults.ll

  Log Message:
  -----------
  [Pipelines] Add LoopSink and DivRemPairs to LTO post-link pipeline

As pointed out in D148010, these passes are missing from the LTO
post-link pipeline. They are present in the pre-link pipeline,
but LoopSink is completely useless there (it will always be fully
undone by LICM post-link) and DivRemPairs is mostly useless
(I believe most of what it does will be undone by InstCombine).

I've not added RelLookupTableConverterPass, because it's also
disabled in the LTO pre-link pipeline, with a comment that there
is an unresolved issue with full LTO.

Compile-time impact of the extra passes is minimal. Of course,
LoopSink will have a larger impact in PGO builds.

Differential Revision: https://reviews.llvm.org/D148343




More information about the All-commits mailing list