[all-commits] [llvm/llvm-project] ae77ac: [Analysis] Remove DA & LegacyDA
Pierre van Houtryve via All-commits
all-commits at lists.llvm.org
Mon Apr 17 00:01:36 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ae77aceba5ad6ee575d3d79eb0259624322b19f4
https://github.com/llvm/llvm-project/commit/ae77aceba5ad6ee575d3d79eb0259624322b19f4
Author: pvanhout <pierre.vanhoutryve at amd.com>
Date: 2023-04-17 (Mon, 17 Apr 2023)
Changed paths:
M llvm/docs/ConvergenceAndUniformity.rst
M llvm/include/llvm/ADT/GenericUniformityInfo.h
R llvm/include/llvm/Analysis/DivergenceAnalysis.h
R llvm/include/llvm/Analysis/LegacyDivergenceAnalysis.h
M llvm/include/llvm/Analysis/Passes.h
R llvm/include/llvm/Analysis/SyncDependenceAnalysis.h
M llvm/include/llvm/Analysis/TargetTransformInfo.h
M llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
M llvm/include/llvm/CodeGen/BasicTTIImpl.h
M llvm/include/llvm/InitializePasses.h
M llvm/include/llvm/LinkAllPasses.h
M llvm/lib/Analysis/Analysis.cpp
M llvm/lib/Analysis/CMakeLists.txt
R llvm/lib/Analysis/DivergenceAnalysis.cpp
R llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp
R llvm/lib/Analysis/SyncDependenceAnalysis.cpp
M llvm/lib/Analysis/TargetTransformInfo.cpp
M llvm/lib/Passes/PassBuilder.cpp
M llvm/lib/Passes/PassRegistry.def
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/always-uniform-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/always-uniform.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/atomics-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/atomics.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/hidden-diverge-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/hidden-diverge.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/branch-outside-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/diverged-entry-basic-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/exit-divergence-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/irreducible-1.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/irreducible-2-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/join-loopexit-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/loads-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/never-uniform.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/temporal-diverge-gmir.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/always_uniform.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/atomics.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/b42473-r1-crash.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/control-flow-intrinsics.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/hidden_diverge.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/hidden_loopdiverge.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/inline-asm.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp_f16.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/intrinsics.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/branch-outside.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-basic.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-headers-nested.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-headers.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/exit-divergence.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/irreducible-1.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/irreducible-2.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/reducible-headers.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/join-at-loop-exit.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/join-at-loop-heart.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/kernel-args.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/lit.local.cfg
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/no-return-blocks.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/phi-undef.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/propagate-loop-live-out.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/read_register.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/temporal_diverge.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/trivial-join-at-loop-exit.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/unreachable-loop-block.ll
R llvm/test/Analysis/DivergenceAnalysis/AMDGPU/workitem-intrinsics.ll
R llvm/test/Analysis/DivergenceAnalysis/NVPTX/daorder.ll
R llvm/test/Analysis/DivergenceAnalysis/NVPTX/diverge.ll
R llvm/test/Analysis/DivergenceAnalysis/NVPTX/hidden_diverge.ll
R llvm/test/Analysis/DivergenceAnalysis/NVPTX/irreducible.ll
R llvm/test/Analysis/DivergenceAnalysis/NVPTX/lit.local.cfg
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/atomics.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/intrinsics.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/kernel-args.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/lit.local.cfg
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/loads.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/no-return-blocks.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/phi-undef.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/unreachable-loop-block.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/workitem-intrinsics.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/NVPTX/diverge.ll
R llvm/test/Analysis/LegacyDivergenceAnalysis/NVPTX/lit.local.cfg
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/always-uniform-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/always-uniform.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/atomics-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/atomics.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/hidden-diverge-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/hidden-diverge.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/branch-outside-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/diverged-entry-basic-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/exit-divergence-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/irreducible-1.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/irreducible-2-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/join-loopexit-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/loads-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/never-uniform.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/temporal-diverge-gmir.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/atomics.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/b42473-r1-crash.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/control-flow-intrinsics.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/hidden_diverge.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/hidden_loopdiverge.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/inline-asm.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/interp_f16.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/intrinsics.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/branch-outside.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-basic.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-headers-nested.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-headers.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/exit-divergence.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/irreducible-1.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/irreducible-2.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/reducible-headers.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/join-at-loop-exit.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/join-at-loop-heart.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/kernel-args.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/lit.local.cfg
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/no-return-blocks.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/phi-undef.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/propagate-loop-live-out.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/temporal_diverge.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/trivial-join-at-loop-exit.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/unreachable-loop-block.ll
A llvm/test/Analysis/UniformityAnalysis/AMDGPU/workitem-intrinsics.ll
A llvm/test/Analysis/UniformityAnalysis/NVPTX/daorder.ll
A llvm/test/Analysis/UniformityAnalysis/NVPTX/diverge.ll
A llvm/test/Analysis/UniformityAnalysis/NVPTX/hidden_diverge.ll
A llvm/test/Analysis/UniformityAnalysis/NVPTX/irreducible.ll
A llvm/test/Analysis/UniformityAnalysis/NVPTX/lit.local.cfg
M llvm/test/CodeGen/AMDGPU/always-uniform.ll
M llvm/test/CodeGen/AMDGPU/smrd.ll
M llvm/unittests/Analysis/CMakeLists.txt
R llvm/unittests/Analysis/DivergenceAnalysisTest.cpp
M llvm/utils/gn/secondary/llvm/lib/Analysis/BUILD.gn
M llvm/utils/gn/secondary/llvm/unittests/Analysis/BUILD.gn
Log Message:
-----------
[Analysis] Remove DA & LegacyDA
UniformityAnalysis offers all of the same features and much more, there is no reason left to use the legacy DAs.
See RFC: https://discourse.llvm.org/t/rfc-deprecate-divergenceanalysis-legacydivergenceanalysis/69538
- Remove LegacyDivergenceAnalysis.h/.cpp
- Remove DivergenceAnalysis.h/.cpp + Unit tests
- Remove SyncDependenceAnalysis - it was not a real registered analysis and was only used by DAs
- Remove/adjust references to the passes in the docs where applicable
- Remove TTI hook associated with those passes.
- Move tests to UniformityAnalysis folder.
- Remove RUN lines for the DA, leave only the UA ones.
- Some tests had to be adjusted/removed depending on how they used the legacy DAs.
Reviewed By: foad, sameerds
Differential Revision: https://reviews.llvm.org/D148116
More information about the All-commits
mailing list