[all-commits] [llvm/llvm-project] d81cdb: Revert D148384 "[Demangle] replace use of llvm::St...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d81cdb49d74064e88843733e7da92db865943509
      https://github.com/llvm/llvm-project/commit/d81cdb49d74064e88843733e7da92db865943509
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    M llvm/include/llvm/Demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/MicrosoftDemangle.h
    M llvm/include/llvm/Demangle/MicrosoftDemangleNodes.h
    M llvm/include/llvm/Demangle/Utility.h
    M llvm/lib/Demangle/DLangDemangle.cpp
    M llvm/lib/Demangle/ItaniumDemangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangleNodes.cpp
    M llvm/lib/Demangle/RustDemangle.cpp
    M llvm/lib/ProfileData/ItaniumManglingCanonicalizer.cpp
    M llvm/unittests/Demangle/ItaniumDemangleTest.cpp
    M llvm/unittests/Demangle/OutputBufferTest.cpp

  Log Message:
  -----------
  Revert D148384 "[Demangle] replace use of llvm::StringView w/ std::string_view"

This reverts commit 3e559509b426b6aae735a7f57dbdaed1041d2622 and e0c4ffa796b553fa78c638a9584c05ac21fe07d5.

This still breaks Windows builds.

In addition, `#include <llvm/ADT/StringViewExtras.h>` in
llvm/include/llvm/Demangle/ItaniumDemangle.h is a library layering violation
(LLVMDemangle is the lowest LLVM library and cannot depend on LLVMSupport).