[all-commits] [llvm/llvm-project] 5abe33: [clang-tidy] Fix false positve for defaulted move ...

Jorge Pinto Sousa via All-commits all-commits at lists.llvm.org
Fri Apr 14 10:45:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5abe338f2a7f6f99708bd268419de6fb6e3da9e3
      https://github.com/llvm/llvm-project/commit/5abe338f2a7f6f99708bd268419de6fb6e3da9e3
  Author: AMS21 <AMS21.github at gmail.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp
    M clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.h
    M clang-tools-extra/clang-tidy/utils/CMakeLists.txt
    A clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.cpp
    A clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.h
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/performance/noexcept-move-constructor-fix.cpp
    M clang-tools-extra/test/clang-tidy/checkers/performance/noexcept-move-constructor.cpp

  Log Message:
  -----------
  [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Previously a struct like this:

template <typename>
struct A { A(A&&) = default; };

Would trigger a false positive, since even though it is not marked as
noexcept it still is due to the `= default`.
Now we only give a warning if the defaulted move constructor is
actually declared as throwing and correctly resolve it if they are
defaulted.

This fixes llvm#56026, llvm#41414, llvm#38081

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D146922


  Commit: 9f3995c051fcbacea4efcea5016943917ff3c400
      https://github.com/llvm/llvm-project/commit/9f3995c051fcbacea4efcea5016943917ff3c400
  Author: Douglas Chen <dougpuob at gmail.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy
    M clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-cfgfile.cpp

  Log Message:
  -----------
  [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

Improve the (`D144510`)[https://reviews.llvm.org/D144510] patch with prefix string. Using "my" instead of "cust" would increase
readability.

Take some examples:
- const char* `custszNamePtr` = "Name"; --> `myszNamePtr`
- uint8_t `custu8ValueU8` = 0; --> `myu8ValueU8`
- DWORD `custdwMsDword` = 0; --> `mydwMsDword`

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D148314


  Commit: e2919f8f49abfd2fa493aeaf4f4a99be1c2bdaae
      https://github.com/llvm/llvm-project/commit/e2919f8f49abfd2fa493aeaf4f4a99be1c2bdaae
  Author: Jorge Pinto Sousa <jorge.pinto.sousa at proton.me>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M clang-tools-extra/docs/clang-tidy/Integrations.rst

  Log Message:
  -----------
  [clang-tidy][NFC] Remove reference to Visual studio native plugin

The clang-tidy documentation contained:

> MS Visual Studio has a native clang-tidy-vs plugin

This plugin was removed via 559ae14.

Fixes: https://github.com/llvm/llvm-project/issues/62142

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D148354


Compare: https://github.com/llvm/llvm-project/compare/f198e0b594aa...e2919f8f49ab


More information about the All-commits mailing list