[all-commits] [llvm/llvm-project] 75f1f1: [symbolizer] Change error message if module not found

Serge Pavlov via All-commits all-commits at lists.llvm.org
Thu Apr 13 23:04:35 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75f1f158812dabc03e70697b6b9c272230bce63d
  Author: Serge Pavlov <sepavloff at gmail.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
    M llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
    M llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
    M llvm/test/DebugInfo/Symbolize/ELF/symtab-file2.yaml
    M llvm/test/DebugInfo/symbolize-missing-file.test
    M llvm/test/tools/llvm-symbolizer/debuginfod-missing-build-id.test
    M llvm/test/tools/llvm-symbolizer/output-style-inlined.test
    M llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
    M llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

  Log Message:
  [symbolizer] Change error message if module not found

If llvm-symbolize did not find module, the error looked like:

    LLVMSymbolizer: error reading file: No such file or directory

This message does not follow common practice: LLVMSymbolizer is not an
utility name. Also the message did not not contain the name of missed file.

With this change the error message looks differently:

    llvm-symbolizer: error: 'abc': No such file or directory

This format is closer to messages produced by other utilities and allow
proper coloring.

Differential Revision: https://reviews.llvm.org/D148032

More information about the All-commits mailing list