[all-commits] [llvm/llvm-project] 57c8fe: [lldb] Add dummy field to RegisterInfo for registe...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57c8fee1b97eb7e70513b935b765f8381a941b18
      https://github.com/llvm/llvm-project/commit/57c8fee1b97eb7e70513b935b765f8381a941b18
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M lldb/include/lldb/lldb-private-types.h
    M lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp
    M lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp
    M lldb/source/Plugins/ABI/ARM/ABISysV_arm.cpp
    M lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.cpp
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp
    M lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp
    M lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp
    M lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextLinux_i386.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextLinux_x86_64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextWindows_i386.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp
    M lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterInfos_arm.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_arm64_sve.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_i386.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_loongarch64.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_mips64.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_powerpc.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64le.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_riscv64.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_s390x.h
    M lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h
    M lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp
    M lldb/source/Plugins/Process/Windows/Common/arm64/RegisterContextWindows_arm64.cpp
    M lldb/source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp
    M lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
    M lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
    M lldb/source/Target/DynamicRegisterInfo.cpp
    M lldb/unittests/tools/lldb-server/tests/MessageObjects.cpp

  Log Message:
  -----------
  [lldb] Add dummy field to RegisterInfo for register flags use later

This structure is supposed to be trivial, so we cannot simply do
"= nullptr;" on the new member. Doing that means you are non trivial,
regardless of whether you emulate the previously implied constructor somehow.

The next option is to update every use of brace initialisation.

Given that this is some hundreds of lines, this change just adds a dummy
pointer that is set to nullptr. Subsequent changes will actually use that
to point to register flags information.

Note: This change is not clang-format-ted because it changes a bunch of
areas that are not themselves formatted. It would just add noise.

Reviewed By: jasonmolenda, JDevlieghere

Differential Revision: https://reviews.llvm.org/D145568