[all-commits] [llvm/llvm-project] 169fde: [opt] Remove the BreakpointPrinter pass

[Björn Pettersson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 169fde63b7cb5734acf7d8c6f8ea3932a001e6b4
      https://github.com/llvm/llvm-project/commit/169fde63b7cb5734acf7d8c6f8ea3932a001e6b4
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    R llvm/tools/opt/BreakpointPrinter.cpp
    R llvm/tools/opt/BreakpointPrinter.h
    M llvm/tools/opt/CMakeLists.txt
    M llvm/tools/opt/opt.cpp
    M llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn

  Log Message:
  -----------
  [opt] Remove the BreakpointPrinter pass

This removed the option print-breakpoints-for-testing in opt, as well
as the related BreakpointPrinter pass.

The functionality only existed for the legacy PM, but was not verified
to be working by any test cases. And the named "llvm.dbg.sp" metadata
that the pass was looking for is not something that I really can find
any information about (unless perhaps if I dive really deep into the
commit history), so not sure exactly if this functionality has been
relevant for several years.

Differential Revision: https://reviews.llvm.org/D148080


  Commit: c00b526f04c992890c1af6b85d5c366164dc4c64
      https://github.com/llvm/llvm-project/commit/c00b526f04c992890c1af6b85d5c366164dc4c64
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M llvm/docs/Passes.rst
    R llvm/tools/opt/AnalysisWrappers.cpp
    M llvm/tools/opt/CMakeLists.txt
    M llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn

  Log Message:
  -----------
  [opt] Remove the ExternalFunctionsPassedConstants pass

This commit is removing the last pieces of AnalysisWrapper.cpp
(including the ExternalFunctionsPassedConstants pass, aka
print-externalfnconstants).

The pass only existed for the legacy PM, and it was not regression
tested. And since the pass did not force the use of the legacy pass
manager there was no simply way to run the pass nowadays, at least
not by using opt.

Differential Revision: https://reviews.llvm.org/D148081


  Commit: 3a3ee933f347af815f111c6f9352baf8cfd302fc
      https://github.com/llvm/llvm-project/commit/3a3ee933f347af815f111c6f9352baf8cfd302fc
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M llvm/tools/opt/opt.cpp

  Log Message:
  -----------
  [opt] Cleanups related to legacy PM deprecation

Remove dead code related to "FPasses". This was a leftover from
commit 7a5332b9b5584ce.

Do not mention -enable-new-pm in error messages. The option does
not exist any longer.

Remove the addPass helper. Only one use remained, so we can just
"inline" it manually to keep the code related to legacy PM a bit
less spread out.

Differential Revision: https://reviews.llvm.org/D148082


  Commit: 410775ecfdb8e7290d6234d7de48a0c94ffddb05
      https://github.com/llvm/llvm-project/commit/410775ecfdb8e7290d6234d7de48a0c94ffddb05
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M llvm/include/llvm/Transforms/IPO/Inliner.h
    M llvm/lib/LTO/UpdateCompilerUsed.cpp
    M llvm/lib/Transforms/IPO/IPO.cpp
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/lib/Transforms/Scalar/Scalar.cpp
    M llvm/lib/Transforms/Utils/Utils.cpp
    M llvm/lib/Transforms/Vectorize/Vectorize.cpp

  Log Message:
  -----------
  [Transforms][LTO] Remove some redundant includes. NFC

No need to include CallGraphSCCPass.h from the IPO/Inliner.

Also removed the include of LegacyPassManager.h in a couple of files
that do not really depend on that header file.

Differential Revision: https://reviews.llvm.org/D148083


Compare: https://github.com/llvm/llvm-project/compare/e0639695d367...410775ecfdb8