[all-commits] [llvm/llvm-project] e38b0f: Remove AArch64 out of MIPS watchpoint-skip, doc wp...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e38b0fa83a933a6b20064a37b8d8ebd9ec1de499
      https://github.com/llvm/llvm-project/commit/e38b0fa83a933a6b20064a37b8d8ebd9ec1de499
  Author: Jason Molenda <jason at molenda.com>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M lldb/docs/lldb-gdb-remote.txt
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/StopInfo.cpp

  Log Message:
  -----------
  Remove AArch64 out of MIPS watchpoint-skip, doc wp description

Watchpoints from lldb-server are sent in the stop info packet
as a `reason:watchpoint` and `description:asciihex` keys; the
latter's asciihex has one to three integer values.  This patch
documents the purpose of those three different numbers, and
clarifies the behavior on MIPS with the third number which is
outside the range of any watched memory range means to silently
skip the watchpoint.

lldb was previously using this silently skip watchpoint behavior
for AArch64 as well, but in the case of AArch64 we see a watchpoint
address outside of a watched memory range when the write BEGINS
before the watched memory range, but extends in to it.  We don't
want to silently skip these.

Differential Revision: https://reviews.llvm.org/D147816
rdar://83996471