[all-commits] [llvm/llvm-project] 9e3aa5: [support] Provide overload to PrintNumber that use...

Paul Kirth via All-commits all-commits at lists.llvm.org
Wed Apr 12 10:59:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e3aa50d39fa208998360cb45793df1e39188d4c
      https://github.com/llvm/llvm-project/commit/9e3aa50d39fa208998360cb45793df1e39188d4c
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M llvm/include/llvm/Support/JSON.h
    M llvm/include/llvm/Support/ScopedPrinter.h
    M llvm/tools/llvm-readobj/ELFDumper.cpp
    M llvm/unittests/Support/JSONTest.cpp

  Log Message:
  -----------
  [support] Provide overload to PrintNumber that use C++ types

This attempts to address an issue with overload resolution for `PrintNumber`
with `size_t` parameters on Darwin, brought up in
https://reviews.llvm.org/D146492.

On Aarch64 Darwin, `uint64_t` has a different typedef than `size_t`
(e.g., `unsigned long long` vs. `unsigned long`), whereas on Linux and
Windows they are the same.

This commit also reverts the static_cast's added in
064e2497e2ebe9ac30ac96923a26a52484300fdf, since they are no longer
needed.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D146771




More information about the All-commits mailing list