[all-commits] [llvm/llvm-project] 53aa22: [lldb-vscode] Fix two issues with runInTerminal test.

Jorge Gorbe Moya via All-commits all-commits at lists.llvm.org
Mon Apr 10 18:18:37 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53aa22cd9ac4a779208cf9907354cc6d4211e783
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    M lldb/test/API/tools/lldb-vscode/runInTerminal/TestVSCode_runInTerminal.py
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/Options.td
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  [lldb-vscode] Fix two issues with runInTerminal test.

With ptrace_scope = 1 the kernel only allows tracing descendants of a
process. When using runInTerminal, the target process is not launched
by the debugger, so we need to modify LaunchRunInTerminal to explicitly
allow tracing. This should fix a problem reported in

In order to allow only the main lldb-vscode process to attach to the
target, this change introduces a new `--debugger-pid` flag that needs
to be passed with `--launch-target` and `--comm-file`.

Also, remove a special case from the launch method in the
lldbvscode_testcase test harness. The existing test was using
stopOnEntry, so the first stop didn't happen at the expected breakpoint
unless the harness did configurationDone first.

Differential Revision: https://reviews.llvm.org/D147805

More information about the All-commits mailing list