[all-commits] [llvm/llvm-project] 26f177: [libc] clean up ctype negative handling

michaelrj-google via All-commits all-commits at lists.llvm.org
Mon Apr 10 10:00:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26f1770e538ece427d5069b897f9e686746797a8
      https://github.com/llvm/llvm-project/commit/26f1770e538ece427d5069b897f9e686746797a8
  Author: Michael Jones <michaelrj at google.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M libc/src/ctype/isblank.cpp
    M libc/src/ctype/iscntrl.cpp
    M libc/test/src/ctype/CMakeLists.txt
    M libc/test/src/ctype/isalnum_test.cpp
    M libc/test/src/ctype/isalpha_test.cpp
    M libc/test/src/ctype/isascii_test.cpp
    M libc/test/src/ctype/isblank_test.cpp
    M libc/test/src/ctype/iscntrl_test.cpp
    M libc/test/src/ctype/isdigit_test.cpp
    M libc/test/src/ctype/isgraph_test.cpp
    M libc/test/src/ctype/islower_test.cpp
    M libc/test/src/ctype/isprint_test.cpp
    M libc/test/src/ctype/ispunct_test.cpp
    M libc/test/src/ctype/isspace_test.cpp
    M libc/test/src/ctype/isupper_test.cpp
    M libc/test/src/ctype/isxdigit_test.cpp
    M libc/test/src/ctype/toascii_test.cpp
    M libc/test/src/ctype/tolower_test.cpp
    M libc/test/src/ctype/toupper_test.cpp

  Log Message:
  -----------
  [libc] clean up ctype negative handling

The ctype functions will sometimes be passed negative numbers, such as
EOF. Some of the previous implementations didn't handle these properly.
Additionally, the tests did not check any negative numbers. These
problems have been fixed.

This patch fixes https://github.com/llvm/llvm-project/issues/62000

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D147813




More information about the All-commits mailing list