[all-commits] [llvm/llvm-project] 636dd1: Make explicit the single-argument constructors of ...

[Aaron Ballman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 636dd1e8a1782e22f9bdee640428ed5c50a4a4f2
      https://github.com/llvm/llvm-project/commit/636dd1e8a1782e22f9bdee640428ed5c50a4a4f2
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttributeCommonInfo.h
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/utils/TableGen/ClangAttrEmitter.cpp

  Log Message:
  -----------
  Make explicit the single-argument constructors of AttributeCommonInfo; NFC

The single-argument constructors of this class were not marked explicit
and that led to some incorrect uses that slipped under the radar (see
changes in SemaDeclAttr.cpp). This makes the constructors explicit,
changes the benignly incorrect uses, and updates the tablegen code to
emit the correct support code to call the explicit constructors.

While this does correct a misuse, that incorrect usage could not be
observed except via a debugger and so no additional tests are added.

Differential Revision: https://reviews.llvm.org/D147661