[all-commits] [llvm/llvm-project] 686ef4: [mlir][sparse] Simplifying Merger::expContainsTensor

wren romano via All-commits all-commits at lists.llvm.org
Fri Apr 7 12:33:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 686ef4b4a8dd0af5639ebac9edb491386a3b6932
      https://github.com/llvm/llvm-project/commit/686ef4b4a8dd0af5639ebac9edb491386a3b6932
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp

  Log Message:
  -----------
  [mlir][sparse] Simplifying Merger::expContainsTensor

`expContainsTensor` used to call `expIsTensor` to short-circuit the recursive calls; however, the very first thing `expContainsTensor` does is to check `expIsTensor`, so the short-circuiting code just causes the function to check that condition redundantly.

Depends On D146684

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D146688




More information about the All-commits mailing list